Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subsumption fix for issue #2189 #2204

Merged
merged 2 commits into from
Mar 10, 2022

Conversation

b-scholz
Copy link
Member

@b-scholz b-scholz commented Mar 9, 2022

This PR fixes issue #2189. The cluster of indices representing a relation requires fully defined comparators for all indices if the relation has a btree_delete qualifier.

Copy link
Member

@julienhenry julienhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the quick fix!

.decl R(a: number, b: number)
R(2,2).

.decl ES(x:number, y:number) btree_delete
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the btree_delete keyword was no longer required ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well - we still have it; if there is a subsumptive rule, btree_delete will be automatically set.

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #2204 (2b50c6f) into master (8893fe8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2204   +/-   ##
=======================================
  Coverage   75.52%   75.52%           
=======================================
  Files         452      452           
  Lines       27394    27396    +2     
=======================================
+ Hits        20689    20691    +2     
  Misses       6705     6705           
Impacted Files Coverage Δ
src/synthesiser/Relation.cpp 98.21% <100.00%> (+0.14%) ⬆️
...ouffle/datastructure/ConcurrentInsertOnlyHashMap.h 88.18% <0.00%> (-1.82%) ⬇️
src/interpreter/Relation.h 91.50% <0.00%> (+0.94%) ⬆️

Copy link
Collaborator

@SamArch27 SamArch27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@SamArch27 SamArch27 merged commit fce85d9 into souffle-lang:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants