separate symbol table interface from implementation #2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2200 +/- ##
==========================================
- Coverage 75.51% 75.25% -0.27%
==========================================
Files 452 454 +2
Lines 27394 27578 +184
==========================================
+ Hits 20687 20753 +66
- Misses 6707 6825 +118
|
|
There seems to be a conflict now. |
|
There is now merge conflict. |
|
@b-scholz I resolved the conflicts. |
b-scholz
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common issue with c++ functors is that they must be compiled with the same OpenMP support as the datalog program that will call them. This change removes this constraint.
It separates interface from implementation, so that c++ functors only have to include the symbol table interface header and don't know about the actual implementation.
Interfaces of
SymbolTableandRecordTableare respectively insouffle/SymbolTable.handsouffle/RecordTable.h. The implementation are respectively insouffle/datastructure/SymbolTableImpl.handsouffle/datastructure/RecordTableImpl.h.Added
souffle/SouffleFunctor.h, the minimal header that c++ functors must include.Any code that used to instantiate
SouffleTableobjects must now includesouffle/datastructure/SymbolTableImpl.hand instantiate theSouffleTableImplclass insteadRelates to #2195