fix souffle-compile argument parsing #2191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2191 +/- ##
==========================================
+ Coverage 75.54% 75.55% +0.01%
==========================================
Files 452 452
Lines 27260 27264 +4
==========================================
+ Hits 20594 20600 +6
+ Misses 6666 6664 -2
|
|
Thanks for the contribution! |
b-scholz
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears the
souffle-compileexecutable/script behaves incorrectly on missing and/or invalid file CLI arguments.E.g., after executing the following:
there is no
foo.java, as the second line deletes the file created by the first. Similarly, not providing an argument or providing an argument with no corresponding file does not error in the expected way.This PR I believes remedies these issues. (At least in some simple hand tests these changes cause the expected error messages to be raised describing what went wrong.)