Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes unsigned range souffle-lang/souffle#2182 #2184

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

quentin
Copy link
Member

@quentin quentin commented Feb 1, 2022

This is a fix for the evaluation of range with unsigned bounds and backward steps.
Also add some tests for the float case.

@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #2184 (bfc54a5) into master (caea609) will increase coverage by 0.33%.
The diff coverage is 92.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2184      +/-   ##
==========================================
+ Coverage   75.26%   75.59%   +0.33%     
==========================================
  Files         452      452              
  Lines       27357    27259      -98     
==========================================
+ Hits        20589    20607      +18     
+ Misses       6768     6652     -116     
Impacted Files Coverage Δ
src/ast/analysis/typesystem/Type.cpp 45.84% <0.00%> (-0.10%) ⬇️
src/ast/transform/FoldAnonymousRecords.h 50.00% <ø> (ø)
src/ast/transform/MagicSet.h 63.26% <ø> (ø)
src/ast/utility/SipsMetric.cpp 21.33% <0.00%> (+5.87%) ⬆️
src/ast/utility/SipsMetric.h 18.18% <0.00%> (+4.84%) ⬆️
src/ast/utility/Utils.h 100.00% <ø> (ø)
src/ast2ram/utility/TranslatorContext.h 100.00% <ø> (ø)
src/include/souffle/utility/FunctionalUtil.h 100.00% <ø> (ø)
src/include/souffle/utility/span.h 100.00% <ø> (ø)
src/ast/transform/ReorderLiterals.cpp 71.42% <50.00%> (+1.15%) ⬆️
... and 67 more

Copy link
Collaborator

@XiaowenHu96 XiaowenHu96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@XiaowenHu96 XiaowenHu96 merged commit d70cf1e into souffle-lang:master Feb 3, 2022
@quentin quentin deleted the fixrange branch February 5, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants