Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow populating and reading ADTs in souffle::tuple interface #2183

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

aeflores
Copy link
Contributor

The asserts checks in the << and >> operators did not allow populating ADT values.
This MR also update the documentation regarding primitive types.

@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #2183 (2e1db5a) into master (b9752d8) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2183      +/-   ##
==========================================
- Coverage   75.55%   75.55%   -0.01%     
==========================================
  Files         452      452              
  Lines       27249    27249              
==========================================
- Hits        20588    20587       -1     
- Misses       6661     6662       +1     
Impacted Files Coverage Δ
src/include/souffle/SouffleInterface.h 88.99% <100.00%> (ø)
src/include/souffle/utility/ParallelUtil.h 84.49% <0.00%> (-0.78%) ⬇️

Copy link
Member

@b-scholz b-scholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a small test-case for +?

@b-scholz b-scholz merged commit a50254f into souffle-lang:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants