Stop using illegal negative values for wgpu::SamplerDescriptor::lod_min_clamp
.
#436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Negative values like
-100.0
are illegal forGPUSamplerDescriptor.lodMinClamp
.More specifically, WebGPU valid usage states that
lodMinClamp
must not be negative, andlodMaxClamp
must be >=lodMinClamp
:Indeed, Chrome's WebGPU implementation complains:
It dislikes it even more when we actually try to sample using this illegal sampler:
This PR changes all the illegal negative values to
0.0
.The value of
0.0
is the default value for ``wgpu::SamplerDescriptor::lod_min_clamp` anyway so technically it can be omitted,but I think being explicit here helps for documentation purposes.