Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename dev/core.pyx to alt_core/core.pyx #80

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Rename dev/core.pyx to alt_core/core.pyx #80

merged 1 commit into from
Feb 19, 2020

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Feb 19, 2020 •
edited by taldcroft
Loading

Description

This puts the core.pyx file into alt-core for consistency with the others.

Testing

  • No testing required since core.pyx is not part of the distribution or xija package.

taldcroft
taldcroft approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I edited the PR description to meet current standards.

@taldcroft taldcroft merged commit 34744b0 into master Feb 19, 2020
@taldcroft taldcroft deleted the jeanconn-move-core-patch branch February 19, 2020 19:01
@chandra-xray chandra-xray mentioned this pull request Feb 20, 2020
Closed
This was referenced Apr 16, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taldcroft taldcroft taldcroft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeanconn @taldcroft