Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AcqStatReportsPage #36

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Update AcqStatReportsPage #36

merged 2 commits into from
Dec 30, 2024

Conversation

javierggt
Copy link
Contributor

@javierggt javierggt commented Sep 27, 2024

Description

This PR updates the acq stat reports section of the SSAWG summary trending page.

These are the current changes:

  • remove special handling for quarterly plots
  • make AcqStatReportsPage inherit from GenericPage instead of ReportsPage (after removing the use of ska_report_ranges)
  • add the plot of failed acquisition rate Vs time
  • add the acquisition success Vs magnitude plot
  • removed table at the bottom (as I figured the information is now in the acquisition success Vs magnitude plot)

Interface impacts

Requires at least acq_stats_reports from sot/acq_stat_reports#9.

Testing

Unit tests

  • No unit tests

Functional tests

I rebase this branch on top of the branch from #35, and generated a test page doing:

twiki_test acq_stat_reports --url https://cxc.cfa.harvard.edu/mta/ASPECT/jgonzalez/acq_stat_reports

output

@taldcroft
Copy link
Member

Nice! I would propose:

  • Add the 25-75 percentile failure rate history since this tells us about stars on the edge.
  • Remove the mag_err vs. mag plot. I don't feel strongly, but mostly this is not saying anything important about acquisition because the observed mags are brighter than any OBC threshold. This droop plot just tells us that there are more warm pixels.

Otherwise looks good.

@javierggt
Copy link
Contributor Author

@taldcroft I just made those changes and updated the test output

@jeanconn
Copy link
Contributor

What's the status of #35 ? I see twiki_test worked OK for this testing.

@javierggt javierggt merged commit dd31b50 into master Dec 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants