Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wrong box page to ssawg report #33

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Add wrong box page to ssawg report #33

merged 1 commit into from
Mar 26, 2024

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Mar 25, 2024 •
edited
Loading

Description

Add wrong box page to ssawg report

Interface impacts

Testing

Unit tests

  • No unit tests

Functional tests

ska3-jeanconn-fido> git rev-parse HEAD
2acd6b29030daaa15b991964a6169247c55bbbdb
ska3-jeanconn-fido> python twiki_wg/ssawg_trending_scraper.py --data-dir /proj/sot/ska/www/ASPECT_ICXC/test_review_outputs/twiki-wg/twiki-wg-pr33

Output to https://icxc.cfa.harvard.edu/aspect/test_review_outputs/twiki-wg/twiki-wg-pr33/ssawg_trending.html

@jeanconn jeanconn marked this pull request as ready for review March 25, 2024 18:39
@jeanconn jeanconn requested a review from taldcroft March 25, 2024 18:39
taldcroft
taldcroft approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

@taldcroft taldcroft merged commit 3b81361 into master Mar 26, 2024
2 checks passed
@taldcroft taldcroft deleted the wrong-box branch March 26, 2024 15:00
@javierggt javierggt mentioned this pull request Mar 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taldcroft taldcroft taldcroft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeanconn @taldcroft