Fix roll optimize deepcopy issue and fix warning in tests

[taldcroft]

Description

This fixes a problem seen in testing of 2025.1rc2, with the root cause being a changed introduced by astropy/astropy#15871.

It also makes a non-impacting change in tests to use Table.pformat() instead of Table.pformat_all(), since they are equivalent in astropy >= 7.0.

Interface impacts

None

Testing

Unit tests

• Mac

ska3-flight-2025.0rc2) ➜  sparkles git:(fix-roll-optimize-deepcopy-issue) git rev-parse --short HEAD
c003f24
(ska3-flight-2025.0rc2) ➜  sparkles git:(fix-roll-optimize-deepcopy-issue) pytest                    
================================================= test session starts =================================================
platform darwin -- Python 3.12.8, pytest-8.3.4, pluggy-1.5.0
rootdir: /Users/aldcroft/git
configfile: pytest.ini
plugins: anyio-4.7.0, timeout-2.3.1
collected 104 items                                                                                                   

sparkles/tests/test_checks.py ............................................................................      [ 73%]
sparkles/tests/test_find_er_catalog.py .....                                                                    [ 77%]
sparkles/tests/test_review.py ...................                                                               [ 96%]
sparkles/tests/test_yoshi.py ....                                                                               [100%]

================================================ 104 passed in 29.43s =================================================

Independent check of unit tests by Javier

• Linux

(ska3-flight-2025.0rc4) jgonzale sparkles $ pytest sparkles/
============================================================= test session starts =============================================================
platform linux -- Python 3.12.8, pytest-8.3.4, pluggy-1.5.0
rootdir: /proj/sot/ska/jgonzalez/git
configfile: pytest.ini
plugins: anyio-4.7.0, timeout-2.3.1
collected 104 items                                                                                                                           

sparkles/tests/test_checks.py ............................................................................                              [ 73%]
sparkles/tests/test_find_er_catalog.py .....                                                                                            [ 77%]
sparkles/tests/test_review.py ...................                                                                                       [ 96%]
sparkles/tests/test_yoshi.py ....                                                                                                       [100%]

======================================================= 104 passed in 80.71s (0:01:20) ========================================================
(ska3-flight-2025.0rc4) jgonzale sparkles $ git rev-parse --short HEAD
c003f24

Functional tests

No functional testing.

[javierggt]

0.8.6 was released two hours ago :)

[taldcroft]

Hah.

[javierggt]

The changes make sense to me and I verified that tests pass.