Update find_er_attitude test for yaw sign change in get/apply sun_pit…

[taldcroft]

Description

This updates the tests of find_er_attitude to reflect the new yaw sign convention introduced in sot/ska_sun#37. All the dyaw values are just flipped in sign but there are no other functional changes.

The test import of Ska.Sun was changed to ska_sun.

Requires

• Add coord_system kwarg to get/apply_sun_pitch_yaw and change default sign ska_sun#37

Interface impacts

The dyaw column in the att_opts table will be flipped in sign from the previous results. This is a good thing since it now reflects directly what we would tell mission planning and engineers for a yaw bias maneuver. I.e. dyaw = +5 deg would imply creating a command load using a positive yaw bias rate input.

Testing

Unit tests

• Mac

(ska3) ➜  sparkles git:(ska-sun-yaw-sign-change) git rev-parse HEAD      
2a96ec2c9d248f81cb06ebe425caeae95804723f
(ska3) ➜  sparkles git:(ska-sun-yaw-sign-change) printenv PYTHONPATH                                   
/Users/aldcroft/git/ska_sun
(ska3) ➜  sparkles git:(ska-sun-yaw-sign-change) python -c "import ska_sun; print(ska_sun.__version__)"
3.13.1.dev1+g3579ca1
(ska3) ➜  sparkles git:(ska-sun-yaw-sign-change) pytest
====================================================== test session starts ======================================================
platform darwin -- Python 3.10.8, pytest-7.2.1, pluggy-1.0.0
rootdir: /Users/aldcroft/git, configfile: pytest.ini
plugins: timeout-2.1.0, anyio-3.6.2
collected 103 items                                                                                                             

sparkles/tests/test_checks.py ............................................................................                [ 73%]
sparkles/tests/test_find_er_catalog.py .....                                                                              [ 78%]
sparkles/tests/test_review.py ..................                                                                          [ 96%]
sparkles/tests/test_yoshi.py ....                                                                                         [100%]

===================================================== 103 passed in 34.73s ======================================================

Independent check of unit tests by Jean

• OSX

(ska3) flame:sparkles jean$ git rev-parse HEAD
2a96ec2c9d248f81cb06ebe425caeae95804723f
(ska3) flame:sparkles jean$ pytest
=========================================================== test session starts ============================================================
platform darwin -- Python 3.10.8, pytest-7.2.1, pluggy-1.0.0
rootdir: /Users/jean/git, configfile: pytest.ini
plugins: timeout-2.1.0, anyio-3.6.2
collected 103 items                                                                                                                        

sparkles/tests/test_checks.py ............................................................................                           [ 73%]
sparkles/tests/test_find_er_catalog.py .....                                                                                         [ 78%]
sparkles/tests/test_review.py ..................                                                                                     [ 96%]
sparkles/tests/test_yoshi.py ....                                                                                                    [100%]

=========================================================== 103 passed in 43.57s
(ska3) flame:sparkles jean$  python -c "import ska_sun; print(ska_sun.__version__)"
3.13.1.dev2+g2ec26c1 # I tested against this from the merged ska_sun pr in the masters channel

Functional tests

No functional testing.