Add too-cold check for fid lights at acquisition #199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanconn
changed the title
taldcroft
requested changes
Oct 20, 2023
taldcroft
reviewed
Oct 20, 2023
taldcroft
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
This looks good now.
My only question is about sot/proseco#388. We'll want to revert this PR once proseco is updated, so we should talk about the bigger picture plan before merging this PR.
|
Closing this as not needed just now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a caution warning for acquisition temperature between -13.5 and -14, and a critical for acquisition temperature < -14C.
Interface impacts
Testing
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
Adds new unit test.