Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update acisops/dpa_check to Move conftest to use testr #623

Closed
javierggt opened this issue Apr 1, 2021 · 5 comments · Fixed by #639
Closed

Update acisops/dpa_check to Move conftest to use testr #623

javierggt opened this issue Apr 1, 2021 · 5 comments · Fixed by #639
Milestone

Comments

@javierggt
Copy link
Contributor

Includes the following merges:

  • PR #29: Move conftest so we can use testr
@javierggt javierggt added this to the 2021.4 milestone Apr 2, 2021
@jeanconn
Copy link
Contributor

jeanconn commented Apr 2, 2021

Not sure why the acis package update issues are coming in without versions...

@jeanconn
Copy link
Contributor

jeanconn commented Apr 2, 2021

Ah; because it looks like "Move conftest to use testr" is what John has named the "release". Do we have a recommended convention for them?

@jeanconn
Copy link
Contributor

jeanconn commented Apr 2, 2021

Or should the code to make an package update issue just also pull the tag corresponding to the release?

@javierggt
Copy link
Contributor Author

ha, right. That always throws me off too.

I have thought that maybe I could change the skare3_tools script it to say "Update {package} to Release {release tag}" instead of using "Update {package} to {release name}". It should be possible and would not require any convention.

@jeanconn
Copy link
Contributor

jeanconn commented Apr 2, 2021

Yeah, that's what I came around to too. Seems no fire under that but might be a good idea to make it easier to see we're getting the right versions in when we look at the list of issues.

@javierggt javierggt mentioned this issue Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants