Add a test of calc_p_safe for two identical catalogs #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanconn
approved these changes
Feb 12, 2020
| assert np.all(aca2.acqs['halfw'] == aca.acqs['halfw']) | ||
|
|
||
| assert aca.acqs.calc_p_safe() == aca2.acqs.calc_p_safe() |
There was a problem hiding this comment.
Thanks @taldcroft . And I would have tried to come back to do this myself (my belt-and-suspenders thinking on this anyway) but thanks for tossing it in!
This was referenced Apr 16, 2020
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For two catalogs that came about in different ways but with the same stars and halfwidths, confirm that the p_safe values are identical. Because the p_safe calculation is independent of how the catalog is constructed this must succeed, but we check it anyway.
Also fixes an unrelated leftover comment.
Testing