Set a temperature dependent mag limit for imposters #118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ideas in imposter stars notebook to set a temperature
and box size-dependentmag limit for imposters.For a given box size, set the mag limit to the magnitude where one expects (statistically) N stars, where N = 2.5 for a 120" box at t_ccd=-10.0. The idea is that statistically on-board you always have imposters fainter than this limit impacting acquisition, and thus they are already accounted for in the acquisition probability model.
With this modification, the proseco probability is only modified if there happen to be brighter-than-normal outliers. This was the original concept of imposters.
This change does significantly impact the estimated p_acq for faint stars, bringing it typically close to the acq prob model.
To do:
Closes #25