Use parse_cm load_dir_from_load_name and test #288
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates a utiliity function to use
parse_cm.paths.load_dir_from_load_name()
instead ofkadi.commands.core.ska_load_dir()
which is deprecated.Interface impacts
None
Testing
Unit tests
This was done in an environment with Deprecate kadi load_ska_dir() in favor of parse_cm load_dir_from_load_name kadi#310 installed.
Independent check of unit tests by Jean
Functional tests
For kicks I modified the
load_name_to_mp_dir()
function always return""
to check test coverage. This failed a number of tests intest_catalog_fetches.py
so that is reassuring.