Set mica agasc calls to use miniagasc* #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
|
Retested after 9eb3930 |
This was referenced Oct 4, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set mica agasc calls to use miniagasc*
This is in response to sot/agasc#155 which changes the default agasc file to the most recent proseco agasc. Overall that makes sense for operations, but bits of the mica code expect columns that aren't present in the proseco agasc. It would probably be useful to update mica to just not use those columns (even for display) but for now I think it makes sense to update the calls in mica to use the miniagasc. And this may end up being somewhat application specific in mica so I didn't set up any configuration for it.
mica tests don't pass with sot/agasc#155
Interface impacts
Testing
Tested against a ska3-masters environment with sot/agasc#155 .
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
No functional testing.