Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable use of agasc supplement for stats and a specific vv use case #258

Merged
merged 3 commits into from
Apr 1, 2021
Merged

Disable use of agasc supplement for stats and a specific vv use case #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c647eb8
Disable use of agasc supplement for stats and a specific vv use case
jeanconn Apr 1, 2021
d7616dc
Relax effective obc vs l1 roll tolerance from 55 to 65
jeanconn Apr 1, 2021
786b4c9
Update a couple vv tests to use fixed versions
jeanconn Apr 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mica/archive/tests/test_asp_l1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

HAS_L1_ARCHIVE = os.path.exists(asp_l1.CONFIG['data_root'])

def compare_obc_and_asol(atts, times, recs, ptol=2, ytol=2, rtol=50):
def compare_obc_and_asol(atts, times, recs, ptol=2, ytol=2, rtol=65):
"""
Check that obc solution and ground solution have relatively close quats.
Note that because the ground aspect solution is not continuous (only run over science obsids
Expand Down Expand Up @@ -59,7 +59,7 @@ def test_get_atts_time():
stop = '2014:005:00:00:00.000'
atts, times, recs = asp_l1.get_atts(start=start, stop=stop)
assert len(atts) == len(times)
compare_obc_and_asol(atts, times, recs, rtol=55)
compare_obc_and_asol(atts, times, recs)
dwells = events.dwells.filter(start, stop)
for dwell in dwells:
if dwell.get_obsid() > 38000:
Expand Down
2 changes: 1 addition & 1 deletion mica/stats/update_acq_stats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ def _deltas_vs_obc_quat(vals, times, catalog):
logger.info("No agasc id for slot {}, skipping".format(slot))
continue
try:
star = agasc.get_star(agasc_id, date=times[0])
star = agasc.get_star(agasc_id, date=times[0], use_supplement=False)
except:
logger.info("agasc error on slot {}:{}".format(
slot, sys.exc_info()[0]))
Expand Down
2 changes: 1 addition & 1 deletion mica/stats/update_guide_stats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ def _deltas_vs_obc_quat(vals, times, catalog):
continue
try:
# This is not perfect for star catalogs for agasc 1.4 and 1.5
star = agasc.get_star(agasc_id, date=times[0])
star = agasc.get_star(agasc_id, date=times[0], use_supplement=False)
except:
logger.info("agasc error on slot {}:{}".format(
slot, sys.exc_info()[0]))
Expand Down
2 changes: 1 addition & 1 deletion mica/vv/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1035,7 +1035,7 @@ def _read_in_data(self):

if ocat_info['type'] == 1:
import agasc
star_info = agasc.get_star(ocat_info['id'])
star_info = agasc.get_star(ocat_info['id'], use_supplement=False)
mock_prop = dict(cel_loc_flag=0,
id_status='OMITTED',
agasc_id=ocat_info['id'],
Expand Down
4 changes: 2 additions & 2 deletions mica/vv/tests/test_vv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@ def test_get_rms_data():

@pytest.mark.skipif('not HAS_VV_ARCHIVE', reason='Test requires vv archive')
def test_get_vv():
obs = vv.get_vv(16504)
obs = vv.get_vv(16504, version=1)
assert np.allclose(obs['slots']['7']['dz_rms'], 0.11610256063309182)

@pytest.mark.skipif('not HAS_L1_ARCHIVE', reason='Test requires L1 archive')
def test_run_vv():
obi = process.get_arch_vv(2121)
obi = process.get_arch_vv(2121, version=3)
assert np.allclose(obi.info()['sim']['max_d_dy'], 0.002197265625)

@pytest.mark.skipif('not HAS_L1_ARCHIVE', reason='Test requires L1 archive')
Expand Down