Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix package data regex #341

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix package data regex #341

merged 1 commit into from
Oct 30, 2024

Conversation

javierggt
Copy link
Contributor

@javierggt javierggt commented Oct 30, 2024

Description

Fixes the regex to specify the package data.

Interface impacts

Testing

Unit tests

Independent check of unit tests by Jean

In [1]: import kadi

In [2]: kadi.test()
============================================== test session starts ===============================================
platform darwin -- Python 3.11.8, pytest-8.0.2, pluggy-1.4.0
PyQt5 5.15.9 -- Qt runtime 5.15.8 -- Qt compiled 5.15.8
rootdir: /Users/jean/miniforge3/envs/ska3-flight-latest/lib/python3.11/site-packages
plugins: astropy-0.11.0, qt-4.4.0, cov-5.0.0, timeout-2.2.0, remotedata-0.4.1, anyio-4.3.0, filter-subpackage-0.2.0, doctestplus-1.2.1, astropy-header-0.2.2, arraydiff-0.6.1, mock-3.14.0
collected 181 items

kadi/commands/tests/test_commands.py .......s............................................................. [ 38%]
...........s                                                                                               [ 44%]
kadi/commands/tests/test_states.py .......................x.........................                       [ 71%]
kadi/commands/tests/test_validate.py ...................                                                   [ 82%]
kadi/tests/test_events.py ..........                                                                       [ 87%]
kadi/tests/test_occweb.py ......................                                                           [100%]

================================================ warnings summary ================================================
jupyter_client/connect.py:27
  /Users/jean/miniforge3/envs/ska3-flight-latest/lib/python3.11/site-packages/jupyter_client/connect.py:27: DeprecationWarning: Jupyter is migrating its paths to use standard platformdirs
  given by the platformdirs library.  To remove this warning and
  see the appropriate new directories, set the environment variable
  `JUPYTER_PLATFORM_DIRS=1` and then run `jupyter --paths`.
  The use of platformdirs will be the default in `jupyter_core` v6
    from jupyter_core.paths import jupyter_data_dir

kadi/commands/tests/test_commands.py: 12 warnings
kadi/commands/tests/test_states.py: 1 warning
kadi/commands/tests/test_validate.py: 1 warning
  /Users/jean/miniforge3/envs/ska3-flight-latest/lib/python3.11/site-packages/tables/node.py:251: DeprecationWarning: `alltrue` is deprecated as of NumPy 1.25.0, and will be removed in NumPy 2.0. Please use `all` instead.
    self._v_objectid = self._g_open()

kadi/tests/test_events.py::test_overlapping_intervals
  /Users/jean/miniforge3/envs/ska3-flight-latest/lib/python3.11/site-packages/django/utils/encoding.py:266: DeprecationWarning: 'locale.getdefaultlocale' is deprecated and slated for removal in Python 3.15. Use setlocale(), getencoding() and getlocale() instead.
    encoding = locale.getdefaultlocale()[1] or 'ascii'

kadi/tests/test_events.py::test_overlapping_intervals
  /Users/jean/miniforge3/envs/ska3-flight-latest/lib/python3.11/site-packages/django/http/request.py:1: DeprecationWarning: 'cgi' is deprecated and slated for removal in Python 3.13
    import cgi

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
======================= 178 passed, 2 skipped, 1 xfailed, 17 warnings in 102.26s (0:01:42) =======================
Out[2]: False

In [3]: kadi.__version__
Out[3]: '7.12.1.dev4+g0ef8959'

Functional tests

Unit tests are the functional test in this case.

@javierggt javierggt requested a review from jeanconn October 30, 2024 20:11
@javierggt javierggt merged commit 0bfd046 into master Oct 30, 2024
4 checks passed
@javierggt javierggt deleted the package branch October 30, 2024 20:20
@javierggt javierggt mentioned this pull request Nov 7, 2024
@javierggt javierggt mentioned this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants