Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make kadi events complete from start of mission #200

Merged
merged 2 commits into from
Mar 21, 2021
Merged

Conversation

taldcroft
Copy link
Member

Description

This makes event processing robust to getting no applicable telemetry or events, thus allowing the start of the event database build process to be set to an early date like 1999:001.

The events3.db3 database was rebuilt from scratch on kady using the updated NOTES.build instructions.

  • Confirmed that key events like Obsid and Manvr showed the expected new events coinciding with the beginning of available CXC L0 engineering telemetry on 1999:204.
  • No errors and only expected processing warnings.

With the merging of this the new events file will be copied to flight.

Testing

  • Passes unit tests on MacOS (using both current flight and the new events database)
  • Functional testing

Functional testing

Used the validate/write_events_cmds.py script to write ECSV text files for each event type corresponding to two date ranges:

  • 1999:240 - 2021:070 (expected to match)
  • 1999:001 - 1999:240 (expected to have new entries)
ska3-kady$ diff -r -q flight new  # 1999:240 to 2021:070
Files flight/orbits.ecsv and new/orbits.ecsv differ   # OK: some few seconds diffs
Files flight/pass_plans.ecsv and new/pass_plans.ecsv differ  # OK, few changes in BOT/EOT like 0345 -> 345
Files flight/rad_zones.ecsv and new/rad_zones.ecsv differ # OK, few seconds diffs
Files flight/safe_suns.ecsv and new/safe_suns.ecsv differ  # OK, float format issues (e.g. 1.0000004 -> 0.9999996)
Files flight/scs107s.ecsv and new/scs107s.ecsv differ  # OK, float format issues

Inspection of the files for the 1999:001 - 1999:240 exports show the expected new values

@taldcroft taldcroft merged commit 593d705 into master Mar 21, 2021
@taldcroft taldcroft deleted the complete-events branch March 21, 2021 11:25
@javierggt javierggt mentioned this pull request Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant