Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain test_ra_dec_roll regression test to a specific date #35

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

taldcroft
Copy link
Member

@taldcroft taldcroft commented Sep 13, 2024

Description

The test_ra_dec_roll regression test includes a star with high-enough proper motion to start failing after a short time. The check of the final summary output looks for stability at the 0.01 arcsec level.

This PR constrains the test date to that of #32 so that the test should always pass.

Fixes #34

Interface impacts

Testing

Unit tests

  • Mac
(ska3) ➜  find_attitude git:(fix-regression-test-again-#34) env PYTHONPATH=/Users/aldcroft/git/ska_helpers:/Users/aldcroft/git/ska_sun pytest
=============================================== test session starts ================================================
platform darwin -- Python 3.11.8, pytest-7.4.4, pluggy-1.4.0
rootdir: /Users/aldcroft/git
configfile: pytest.ini
plugins: timeout-2.2.0, anyio-4.3.0
collected 24 items                                                                                                 

find_attitude/tests/test_find_attitude.py ........................                                           [100%]

=============================================== 24 passed in 58.70s ================================================
(ska3) ➜  find_attitude git:(fix-regression-test-again-#34) git rev-parse HEAD
950622081e2191feed41ebffe5f6e6e0643c1d6b

Independent check of unit tests by Jean

  • Mac
(ska3-flight-accel) flame:find_attitude jean$ git rev-parse HEAD
950622081e2191feed41ebffe5f6e6e0643c1d6b
(ska3-flight-accel) flame:find_attitude jean$ pytest
============================================================= test session starts ==============================================================
platform darwin -- Python 3.11.8, pytest-7.4.4, pluggy-1.4.0
rootdir: /Users/jean/git
configfile: pytest.ini
plugins: astropy-0.11.0, cov-5.0.0, timeout-2.2.0, remotedata-0.4.1, anyio-4.3.0, filter-subpackage-0.2.0, doctestplus-1.2.1, astropy-header-0.2.2, hypothesis-6.112.0, arraydiff-0.6.1, mock-3.14.0
collected 24 items                                                                                                                             

find_attitude/tests/test_find_attitude.py ........................                                                                       [100%]

============================================================= 24 passed in 54.87

Functional tests

I confirmed that test_ra_dec_roll was failing locally prior to the fix.

Copy link
Contributor

@jeanconn jeanconn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was concerned this change would reduce coverage for the case of no Constraints, but technically you've increased test coverage by adding a test of off_nom_roll_max=None.

@taldcroft
Copy link
Member Author

I was concerned this change would reduce coverage for the case of no Constraints, but technically you've increased test coverage by adding a test of off_nom_roll_max=None.

There is still at least one test with no constraints.

@taldcroft taldcroft merged commit 0b22b6b into master Sep 14, 2024
2 checks passed
@taldcroft taldcroft deleted the fix-regression-test-again-#34 branch September 14, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_ra_dec_roll still failing
2 participants