Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update computed pitch expected vals for a regression test #254

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Dec 10, 2023

Description

Update computed pitch expected vals for a regression test. These pitch values need update after change to position_accurate in ska_sun.

Interface impacts

Testing

Unit tests

  • Linux

Functional tests

No functional testing.

@jeanconn jeanconn requested a review from taldcroft December 10, 2023 02:51
Copy link
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this case is a little different from sot/sparkles#201, so approved.

@jeanconn jeanconn merged commit 0c7e1f1 into master Dec 11, 2023
2 checks passed
@jeanconn jeanconn deleted the update-computed-pitch-test-vals branch December 11, 2023 16:51
@javierggt javierggt mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants