Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acquisition probability model 2020-02 and make it default #88

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

taldcroft
Copy link
Member

@taldcroft taldcroft commented Jan 23, 2020

See StarWorkingGroupMeeting2020x01x29 for more context.

This adds the 2020-02 acq prob model and updates the default model to 2020-02 and adds tests, including two conceptually new ones:

  • Ensure that the default model matches expectation
  • Ensure that the MD5 sum of the 2020-02 FITS data file matches expectation.

This should be promoted to flight only in conjunction with the MATLAB 2019_210 release.

Testing

  • Pass unit tests on MacOS
  • Pass unit tests on linux
  • Integration testing with proseco (need to change testing there?)

@taldcroft taldcroft changed the title Change default acquisition probability model to 2020-02 Add acquisition probability model to 2020-02 and make it default Jan 23, 2020
@taldcroft taldcroft changed the title Add acquisition probability model to 2020-02 and make it default Add acquisition probability model 2020-02 and make it default Jan 23, 2020
@jeanconn
Copy link
Contributor

Passes for me on fido.

With regard to proseco, should we strip out all of the thumbs_up testing while in there? Seems basically unsupported so maintenance seems unwarranted.

@jeanconn jeanconn merged commit 86b93c3 into master Feb 11, 2020
@jeanconn jeanconn deleted the acq-model-2020-02 branch February 11, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants