Allow None input to convert_time_format_spk #163
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue in
convert_time_format_spk
where it ended up wrappingNone
as a numpy array with object dtype. The subsequent code inCxoTime
then did not recognize that asNone
and failed.Interface impacts
None
Testing
Unit tests
Independent check of unit tests by Jean
Functional tests
No functional testing. Just an FYI that this issue is not a problem in
cxotime.convert_time_format
: