Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for public use. #195

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Update for public use. #195

merged 3 commits into from
Dec 6, 2024

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Nov 19, 2024

Description

This PR:

  • Removes references to text files no longer supported.
  • Updates the text to explain what the agasc package is.

Interface impacts

Testing

Unit tests

Docs only update - tests not run

@jeanconn jeanconn requested a review from javierggt November 19, 2024 18:35
@jeanconn
Copy link
Contributor Author

Though if we're going to include the catalog-description.rst as the public docs for AGASC 1.8, it probably needs a link within it to the github docs to explain what an "agasc package query" is.

@jeanconn jeanconn changed the title Remove references to text files no longer supported Update for public use. Nov 19, 2024
@jeanconn jeanconn requested review from javierggt and removed request for javierggt November 27, 2024 15:59
@jeanconn
Copy link
Contributor Author

jeanconn commented Dec 2, 2024

I'm planning to ignore unrelated ruff issues.

@jeanconn jeanconn requested review from javierggt and removed request for javierggt December 4, 2024 17:26
@jeanconn jeanconn merged commit 61418f2 into master Dec 6, 2024
1 of 2 checks passed
@jeanconn jeanconn deleted the remove-ref-to-text-files branch December 6, 2024 15:15
@javierggt javierggt mentioned this pull request Dec 9, 2024
@javierggt javierggt mentioned this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants