Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle bad stars from supplement in one test #191

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Handle bad stars from supplement in one test #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion agasc/tests/test_agasc_2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,10 +427,14 @@ def test_supplement_get_agasc_cone():
)
ok = stars2["MAG_CATID"] == agasc.MAG_CATID_SUPPLEMENT

change_names = ["MAG_CATID", "COLOR1", "MAG_ACA", "MAG_ACA_ERR"]
change_names = ["MAG_CATID", "COLOR1", "MAG_ACA", "MAG_ACA_ERR", "CLASS"]
for name in set(stars1.colnames) - set(change_names):
assert np.all(stars1[name] == stars2[name])

# For CLASS the only ones that are different should have the "bad" class 100
class_nok = stars2["CLASS"] != stars1["CLASS"]
assert np.all(stars2["CLASS"][class_nok] == 100)

assert not np.any(stars1["MAG_CATID"] == agasc.MAG_CATID_SUPPLEMENT)

# At least 35 stars in this field observed
Expand Down