In agasc supplement processing, only process observations that already happened. #154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To determine that an observation already happened, I use
kadi.events.dwells
. I only consider observations before the last dwell inkadi.events
. This avoids theNo level 0 data
in weekly processing.Interface impacts
None
Testing
Unit tests
Independent check of unit tests by Jean
Functional tests
As a quick test that this PR does "something", I did the following, which succeeds on this branch, but fails in current master (and is the cause of the
No level 0 data
error):