Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruff and add pre-commit #52

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Update ruff and add pre-commit #52

merged 4 commits into from
Feb 13, 2024

Conversation

javierggt
Copy link
Contributor

Description

Update to the latest ruff and add pre-commit.

Interface impacts

Testing

Unit tests

  • No unit tests
  • Mac
  • Linux
  • Windows

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

No functional testing.

@javierggt javierggt requested a review from taldcroft February 7, 2024 20:32
Copy link
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good except the pre-commit version number.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
@javierggt javierggt requested a review from taldcroft February 8, 2024 15:40
@javierggt
Copy link
Contributor Author

Fixed.

Copy link
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javierggt javierggt merged commit c05d200 into master Feb 13, 2024
3 checks passed
@javierggt javierggt deleted the ruff branch February 13, 2024 14:51
This was referenced Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants