Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QuatDescriptor for typed-descriptor-lazy-default #45

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

taldcroft
Copy link
Member

Description

This makes a few changes for compatibility with sot/ska_helpers#54.

Interface impacts

None

Testing

Unit tests

  • Mac
(masters) ➜  cxotime git:(cxotime-descr) git rev-parse HEAD                                                             
f0f3d24d17f318c54b483e644ead80142b7439e1
(masters) ➜  cxotime git:(cxotime-descr) pytest
===================================================== test session starts ======================================================
platform darwin -- Python 3.10.8, pytest-7.2.1, pluggy-1.0.0
rootdir: /Users/aldcroft/git, configfile: pytest.ini
plugins: timeout-2.1.0, anyio-3.6.2
collected 235 items                                                                                                            

cxotime/tests/test_cxotime.py .......................................................................................... [ 38%]
........................................................................................................................ [ 89%]
.........................                                                                                                [100%]

===================================================== 235 passed in 2.15s ======================================================

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

No functional testing.

@taldcroft taldcroft requested a review from javierggt January 6, 2024 12:19
Copy link
Contributor

@javierggt javierggt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I ran the tests and verified that a list default fails with the lazy-default descriptor, and the test passes with this branch.

@taldcroft taldcroft merged commit d89586e into master Jan 9, 2024
2 checks passed
@taldcroft taldcroft deleted the typed-descriptor-lazy-default branch January 9, 2024 20:10
@javierggt javierggt mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants