-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving Docs #16
Improving Docs #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maybe these broadcasting changes ended up on the wrong branch?
(and I see they are now removed 👍 from this branch; but it looks like github won't let me just delete this as it is a review comment).
@@ -0,0 +1,264 @@ | |||
|
|||
Quaternion Quick Facts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not re-verified the math here. It is a great idea to have it but not sure if it will get peer review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the question about wanting the equatorial keyword in those docstring lines, this looks good to me.
Following issue #11. This pull request improves documentation in two ways:
There are still a couple of things I would like to do, but I would like to know what your expectations are. Is this enough? Do you need more explanation?