-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NetworkManager] Get system-connections files from other locations #3876
[NetworkManager] Get system-connections files from other locations #3876
Conversation
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
sos/report/plugins/networkmanager.py
Outdated
for _, _, files in os.walk( | ||
"/etc/NetworkManager/system-connections"): | ||
def postproc_system_connections(self, sc_path): | ||
for _, _, files in os.walk(sc_path): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use do_path_regex_sub()
?
sos/sos/report/plugins/kubernetes.py
Lines 291 to 292 in 279ea13
pathexp = fr'^({"|".join(list(self.files)+self.config_files)})' | |
self.do_path_regex_sub(pathexp, regexp, subst) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, I think that would make sense, that would cover all files in the directory
cd7ba2f
to
26914e0
Compare
system-connections files can be found not only under /etc/NetworkManager, but also /usr/lib/NetworkManager and /run/NetworkManager, so we need to capture and post process these locations as well. Resolves: sosreport#3875 Signed-off-by: Jose Castillo <[email protected]>
26914e0
to
2f39d3d
Compare
system-connections files can be found not only under /etc/NetworkManager, but also /usr/lib/NetworkManager and /run/NetworkManager, so we need to capture and post process these locations as well.
Resolves: #3875
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines