Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[man] List --plugopts variant of -k/--plugin-option #3865

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

pmoravec
Copy link
Contributor

@pmoravec pmoravec commented Dec 5, 2024

--plugopts is yet another alternative to -k/--plugin-option that sos report accepts. Let list it in man pages.

Resolves: #3865


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

--plugopts is yet another alternative to -k/--plugin-option that sos
report accepts. Let list it in man pages.

Resolves: sosreport#3865

Signed-off-by: Pavel Moravec <[email protected]>
@pmoravec pmoravec force-pushed the sos-pmoravec-man-plugopts branch from b7ff51b to ecca631 Compare December 5, 2024 12:42
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3865
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@arif-ali
Copy link
Member

arif-ali commented Dec 5, 2024

Looks like the cirrus Ignore for man pages didn't work (that needs rework) and I got the regex/conditional wrong :(

@pmoravec
Copy link
Contributor Author

pmoravec commented Dec 5, 2024

Looks like the cirrus Ignore for man pages didn't work (that needs rework) and I got the regex/conditional wrong :(

Good spot. But what is wrong, compared to https://github.com/wezm/cirrus-ci-docs/blob/master/docs/guide/writing-tasks.md#supported-functions ? Maybe the name of property &man-changes-include is not supported..?

@arif-ali
Copy link
Member

arif-ali commented Dec 5, 2024

Looks like the cirrus Ignore for man pages didn't work (that needs rework) and I got the regex/conditional wrong :(

Good spot. But what is wrong, compared to https://github.com/wezm/cirrus-ci-docs/blob/master/docs/guide/writing-tasks.md#supported-functions ? Maybe the name of property &man-changes-include is not supported..?

Reading in the yaml spec, the anchor is valid, as I've also used - in other anchors too. So curious on what's gone wrong here. Maybe we need double star ?

skip: &man-changes-include "changesIncludeOnly('man/**')"

Copy link
Member

@arif-ali arif-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TurboTurtle TurboTurtle added the Reviewed/Ready for Merge Has been reviewed, ready for merge label Dec 5, 2024
@TurboTurtle TurboTurtle merged commit 09f18b3 into sosreport:main Dec 5, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed/Ready for Merge Has been reviewed, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants