Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sunbeam] Forbid pki folder & manifest inclusion #3862

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

arif-ali
Copy link
Member

@arif-ali arif-ali commented Dec 3, 2024

  • Forbid the pki folder collection newly added recently
  • Add manifest collection from sunbeam

Related: SET-813


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

* Forbid the pki folder collection newly added recently
* Add manifest collection from sunbeam

Related: SET-813

Signed-off-by: Arif Ali <[email protected]>
@arif-ali arif-ali added the Kind/Ubuntu Ubuntu related item label Dec 3, 2024
@arif-ali arif-ali added this to the 4.8.2 milestone Dec 3, 2024
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3862
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@arif-ali
Copy link
Member Author

arif-ali commented Dec 3, 2024

Putting this to draft, as I want to test anything further just in case we need anything else as I'm hearing back from Engineering too on a couple of things. If I don't hear anything by EoW, I'll open this up for review

@arif-ali arif-ali added Status/Canonical Eng Canonical Engineering has been requested to review Status/Needs Review This issue still needs a review from project members and removed Status/Canonical Eng Canonical Engineering has been requested to review labels Dec 3, 2024
@arif-ali arif-ali marked this pull request as ready for review December 4, 2024 09:43
@TurboTurtle TurboTurtle added Reviewed/Ready for Merge Has been reviewed, ready for merge and removed Status/Needs Review This issue still needs a review from project members labels Dec 4, 2024
@TurboTurtle TurboTurtle merged commit bdfc9ab into sosreport:main Dec 4, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind/Ubuntu Ubuntu related item Reviewed/Ready for Merge Has been reviewed, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants