Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NetworkManager] Capture /var/run/NetworkManager folder #3833

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jcastill
Copy link
Member

@jcastill jcastill commented Nov 5, 2024

Capture /var/run/NetworkManager folder

Related: NMT-1074


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

Capture /var/run/NetworkManager folder

Related: NMT-1074

Signed-off-by: Jose Castillo <[email protected]>
@jcastill
Copy link
Member Author

jcastill commented Nov 5, 2024

Draft PR for now - I'm waiting for confirmation that no passwords or secrets are present in any file in /var/run/

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3833
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@arif-ali
Copy link
Member

arif-ali commented Nov 6, 2024

looking at my laptop, there were a few you don't want to collect, or obfuscate

  • forbid /var/lib/NetworkManager/secret_key

There are multiple folders in /var/lib/NetworkManager/backups, and a name of all the connections of the interfaces/wifi networks. So, for example I had the following, and ideally you want to obfuscate the psk

[connection]
id=arif-home
uuid=01110bb1-4f7d-4ef6-9440-17a72f86891c
type=wifi
interface-name=wlp166s0

[wifi]
mode=infrastructure
ssid=arif-home

[wifi-security]
key-mgmt=wpa-psk
psk=<to-be-obfuscated>

[ipv4]
method=auto

[ipv6]
addr-gen-mode=stable-privacy
method=disabled

[proxy]

@arif-ali arif-ali added the Status/Need More Info Feedback is required to reproduce issue or to continue work label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status/Need More Info Feedback is required to reproduce issue or to continue work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants