[collect] Fix exception while parsing sos help

[jcastill]

While parsing the output of 'sos report -l', we
were attempting to split an empty line, and
getting the following exception:

[:_regex_sos_help] Error parsing sos help: list index out of range

Related: #3827

---

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

• Is the commit message split over multiple lines and hard-wrapped at 72 characters?
• Is the subject and message clear and concise?
• Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
• Does the commit contain a Signed-off-by: First Lastname [email protected]?
• Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
• Are all passwords or private data gathered by this PR obfuscated?

[packit-as-a-service]

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

• sudo yum install -y dnf-plugins-core on RHEL 8
• sudo dnf install -y dnf-plugins-core on Fedora
• dnf copr enable packit/sosreport-sos-3830
• And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

[jcastill]

We could do something else instead of calling split() twice, let me know if you have any other preference.

[pmoravec]

Yeah I am on torns here. Comparing performance on big text files:

if line.split():
    print(line.split()[0])

took:

real	0m5.488s
user	0m5.090s
sys	0m0.324s

while:

ls = line.split()
if ls:
    print(ls[0])

took:

real	0m4.161s
user	0m3.841s
sys	0m0.252s

[jcastill]

Then lets go for the second option

[arif-ali]

restarting the failed job

[TurboTurtle]

If we're concerned about empty lines, and we're concerned about performance given the earlier conversation, then we should be applying the conditional before the .split().

for line in results.splitlines():
    if not is_list:
        if not line:
            continue
    [...]

[jcastill]

I tried this, and it covers all the empty lines, but there's a case where we print a single space and the exception gets printed. Playing with the output, this is what we get:

'a python.hashes             off             collect hashes for all python files'
'a rpm.rpmq                  on              query package information with rpm -q'
'a rpm.rpmva                 off             verify all packages'
'a rpm.rpmdb                 off             collect /var/lib/rpm'
'a selinux.fixfiles          off             collect incorrect file context labels'
'a services.servicestatus    off             collect status of all running services'
'a ssh.userconfs             on              Changes whether module will collect user .ssh configs'
''
' '
[localhost:_regex_sos_help] Error parsing sos help: list index out of range

That space is coming from here:

https://github.com/sosreport/sos/blob/main/sos/report/__init__.py#L1093

Any simple way to cover this case as well, without having to change the code in report?
A walrus operator here would be more useful and cover all cases, but we are still waiting for a decision on #3533 , right?

[arif-ali]

@jcastill walrus is good, we already discussed this in #3811

[jcastill]

Perfect, I'll push a new version soon