-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[telegraf] Add new telegraf plugin #3581
Conversation
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also look out for service status. You could potentially add
services = ('telegraf',)
under the files on line 20
ac732ab
to
ade3ae1
Compare
@arif-ali, added the 'services' line. |
Per https://github.com/influxdata/telegraf/blob/master/docs/CONFIGURATION.md , there can be passwords in the main config file (and also in |
8771841
to
15f76af
Compare
Hey @pmoravec. Thanks for your comments. Indeed I missed the password obfuscation part. Please have a look at my latest patch where I added password and certificate obfuscation. |
15f76af
to
79d727a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Thanks for prompt feedback and first PR (to be merged soon)!
Signed-off-by: Marcin Wilk <[email protected]>
79d727a
to
585f5b2
Compare
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines