[kubernetes] Capture json output for nodes

[jcastill]

json outputs are easier to parse than the default
output, so lets capture these.

Resolves: #3484

Co-authored-by: Hervé CHIBOIS

---

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

• Is the commit message split over multiple lines and hard-wrapped at 72 characters?
• Is the subject and message clear and concise?
• Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
• Does the commit contain a Signed-off-by: First Lastname [email protected]?
• Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

[jcastill]

This is a result of the conversation from the issue linked above. I'm not sure about changing the output directly to json, I think it may be better to have json and default output, but I've opened this so we can discuss either option.

[packit-as-a-service]

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

• sudo yum install -y dnf-plugins-core on RHEL 8
• sudo dnf install -y dnf-plugins-core on Fedora
• dnf copr enable packit/sosreport-sos-3509
• And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

[pmoravec]

As we are changing the formatted string, could we move to f-string already..?

[arif-ali]

so we are using kube_get_cmd only in 2 places for json output the rest is standard output? If we're going to change it for one, shouldn't we change it for all?

Personally, if I am looking at it, I would ideally look at the standard output, and then potentially if parsing through jq or other tools is required, I would then look at the json. Would it make sense to have both human-readable files as well as the json output?

[jcastill]

That's what I was thinking, to gather both. In this case we don't lose any data and users and scripts can process both without having to transform what we currently capture. Only thing I'd modify perhaps is to add the jsons in a specific directory but that may break things now. So, both 'normal' and 'json' in the same directories where they are captured?

[hchybz]

This is a result of the conversation from the issue linked above. I'm not sure about changing the output directly to json, I think it may be better to have json and default output, but I've opened this so we can discuss either option.

Sure you should keep both format "TEXT" and "JSON" depending of who is dealing with logs (human or machine)

[arif-ali]

@jcastill any updates on this one?

[jcastill]

@arif-ali I'll check what else I need to add and push a new version if needed.