Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[snaps] when using --all-logs some command outputs will not be collected #3683

Closed
arif-ali opened this issue Jun 21, 2024 · 2 comments · Fixed by #3684
Closed

[snaps] when using --all-logs some command outputs will not be collected #3683

arif-ali opened this issue Jun 21, 2024 · 2 comments · Fixed by #3684
Labels
Kind/Ubuntu Ubuntu related item
Milestone
4.8.0

Comments

@arif-ali
Copy link
Member

arif-ali commented Jun 21, 2024 •
edited
Loading

Working with one of my engineering team members we discovered that snap command outputs will not be collected on the filesystem due to the strict confinement of snaps and hence not having permissions to the destination. A lot of snap related have been added over the past 6 months, and first time we've discovered this issue.

The output from STDOUT to files was introduced in PR #2729 to improve the memory management and speed of collection of the corresponding commands.

Some of the data around this is documented in Launchpad [1]

One possible workaround is that we could have a disable this feature with all logs if the command being run is a command from a snap, but I'll think of an idea on how we can achieve this moving forward.

[1] https://launchpad.net/bugs/2069941
@arif-ali arif-ali added the Kind/Ubuntu Ubuntu related item label Jun 21, 2024
@arif-ali arif-ali added this to the 4.8.0 milestone Jun 21, 2024
@arif-ali arif-ali assigned arif-ali and unassigned arif-ali Jun 21, 2024
arif-ali added a commit to arif-ali/sos that referenced this issue Jun 21, 2024
@arif-ali
[snap,common] If snap don't use to_file
d87edf9 
Resolves: sosreport#3683

Signed-off-by: Arif Ali <[email protected]>
@TurboTurtle
Copy link
Member

TurboTurtle commented Jun 22, 2024 •
edited
Loading

Just to clarify, this is happening when sos is installed as a snap, yes? Not that the commands we are trying to collect are installed from snaps?

@arif-ali
Copy link
Member Author

So, this is when a package is a snap, and hence the command is being run from that snap package.

i.e. the maas plugin is triggered, the maas status command will run, but will not be able to get the output directly to the file due to snap confinement restrictions

arif-ali added a commit to arif-ali/sos that referenced this issue Jun 22, 2024
@arif-ali
[snap,common] If snap don't use to_file
6f877c9 
Resolves: sosreport#3683

Signed-off-by: Arif Ali <[email protected]>
arif-ali added a commit to arif-ali/sos that referenced this issue Jun 22, 2024
@arif-ali
[snap,common] If snap don't use to_file
5a56c02 
Resolves: sosreport#3683

Signed-off-by: Arif Ali <[email protected]>
@arif-ali arif-ali mentioned this issue Jun 22, 2024
Merged
6 tasks
arif-ali added a commit to arif-ali/sos that referenced this issue Jun 25, 2024
@arif-ali
[snap,common] If snap don't use to_file
3c13576 
Resolves: sosreport#3683

Signed-off-by: Arif Ali <[email protected]>
arif-ali added a commit to arif-ali/sos that referenced this issue Jun 27, 2024
@arif-ali
[common] handle all_logs when snap package is installed
908c6e4 
When using `_outfile` in the first `Popen` and the command beig run
is a snap, then this will not work, and will not write to the file and
will be blank.

Dividing this into 2, and use `cat` as the second and grabbing it from
the PIPE solves this problem.

Resolves: sosreport#3683

Signed-off-by: Arif Ali <[email protected]>
arif-ali added a commit to arif-ali/sos that referenced this issue Aug 8, 2024
@arif-ali
[common] handle all_logs when snap package is installed
b48a965 
Add a new flag to add_cmd_output to suggest a snap_cmd, so that sos
does not direct the command directly to a file.

Resolves: sosreport#3683

Signed-off-by: Arif Ali <[email protected]>
arif-ali added a commit to arif-ali/sos that referenced this issue Aug 8, 2024
@arif-ali
[common] handle all_logs when snap package is installed
c8737aa 
Add a new flag to add_cmd_output to suggest a snap_cmd, so that sos
does not direct the command directly to a file.

Resolves: sosreport#3683

Signed-off-by: Arif Ali <[email protected]>
arif-ali added a commit to arif-ali/sos that referenced this issue Aug 8, 2024
@arif-ali
[common] handle all_logs when snap package is installed
1ff241e 
Add a new flag to add_cmd_output to suggest a snap_cmd, so that sos
does not direct the command directly to a file.

Resolves: sosreport#3683

Signed-off-by: Arif Ali <[email protected]>
arif-ali added a commit to arif-ali/sos that referenced this issue Aug 8, 2024
@arif-ali
[common] handle all_logs when snap package is installed
f0413be 
Add a new flag to add_cmd_output to suggest a snap_cmd, so that sos
does not direct the command directly to a file.

Resolves: sosreport#3683

Signed-off-by: Arif Ali <[email protected]>
filanov pushed a commit to filanov/doca-sosreport that referenced this issue Nov 24, 2024
@arif-ali @filanov
[common] handle all_logs when snap package is installed
6b4849c 
Add a new flag to add_cmd_output to suggest a snap_cmd, so that sos
does not direct the command directly to a file.

Resolves: sosreport#3683

Signed-off-by: Arif Ali <[email protected]>
filanov pushed a commit to NVIDIA/doca-sosreport that referenced this issue Nov 25, 2024
@arif-ali @filanov
[common] handle all_logs when snap package is installed
4afcc5e 
Add a new flag to add_cmd_output to suggest a snap_cmd, so that sos
does not direct the command directly to a file.

Resolves: sosreport#3683

Signed-off-by: Arif Ali <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Kind/Ubuntu Ubuntu related item
Projects
None yet
Milestone
4.8.0
Development

Successfully merging a pull request may close this issue.

[common] handle all_logs when snap package is installed arif-ali/sos
2 participants
@arif-ali @TurboTurtle