[sos] Don't double log error level messages

Only set the logging handler that prints ERROR level messages to console if we're running in quiet mode, as otherwise we'll double log from the normal console handler. Closes: #1999 Resolves: #2033 Signed-off-by: Jake Hunsaker <[email protected]>
sosreport · Apr 28, 2020 · ab44373 · ab44373
1 parent 1417827
commit ab44373
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/sos/component.py b/sos/component.py
@@ -202,7 +202,9 @@ def _setup_logging(self):
             else:
                 console.setLevel(logging.WARNING)
             self.soslog.addHandler(console)
-            # log ERROR or higher logs to stderr instead
+        # still log ERROR level message to console, but only setup this handler
+        # when --quiet is used, as otherwise we'll double log
+        else:
             console_err = logging.StreamHandler(sys.stderr)
             console_err.setFormatter(logging.Formatter('%(message)s'))
             console_err.setLevel(logging.ERROR)