Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EstimatedTableRowsCount to avoid count in large tables #366

Merged
merged 5 commits into from
Jun 18, 2018
Merged

Add EstimatedTableRowsCount to avoid count in large tables #366

merged 5 commits into from
Jun 18, 2018

Conversation

allisson
Copy link
Contributor

Fix #168

@wiliamsouza
Copy link

Can you provide some tests?

@allisson
Copy link
Contributor Author

@wiliamsouza test_EstimatedTableRowsCount 👍

@sosedoff
Copy link
Owner

Looks good, i'd add a test to verify TableRowsCount works with a large table, which you can create and fill dynamically.

@allisson
Copy link
Contributor Author

@sosedoff sounds good.

@allisson
Copy link
Contributor Author

@sosedoff Take a look at the tests

@sosedoff
Copy link
Owner

Tests look good. I think you forgot to include schema name in the estimated row count sql query.

@allisson
Copy link
Contributor Author

@sosedoff done 👍

@sosedoff sosedoff merged commit 41a99be into sosedoff:master Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@allisson @wiliamsouza @sosedoff