fix issue 1793

* fix issue 1793 kubernetes#1793 *add tests Signed-off-by: jose luis <[email protected]>
sosan · Jan 22, 2024 · 92b4321 · 92b4321
1 parent 7227d1a
commit 92b4321
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/pkg/transformer/kubernetes/k8sutils_test.go b/pkg/transformer/kubernetes/k8sutils_test.go
@@ -705,6 +705,14 @@ func TestFormatEnvName(t *testing.T) {
 			},
 			want: "app-env",
 		},
+		{
+			name: "check that not begins with -",
+			args: args{
+				name:        "src/app/.env",
+				serviceName: "app",
+			},
+			want: "app-env",
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {

diff --git a/pkg/transformer/kubernetes/kubernetes.go b/pkg/transformer/kubernetes/kubernetes.go
@@ -242,7 +242,7 @@ func (k *Kubernetes) InitConfigMapForEnv(name string, opt kobject.ConvertOptions
 		},
 		ObjectMeta: metav1.ObjectMeta{
 			Name:   envName,
-			Labels: transformer.ConfigLabels(name + "-" + envName),
+			Labels: transformer.ConfigLabels(envName),
 		},
 		Data: envs,
 	}