Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed windows cargo build issue #2

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

0xDaybreak
Copy link
Contributor

When trying to build the reoserv the cargo build fails with Unknown protocol path: eo-protocol\xml\protocol.xml
The issue was caused because of the fact that all the arms of the match protocol_path.to_str() in build.rs were using hardcoded Unix separator.

Copy link
Owner

@sorokya sorokya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This is what I get for never testing on windows haha.

Tested and still works on Mac/Linux and now on Windows :)

@sorokya sorokya merged commit a02fea4 into sorokya:master Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants