Add prettier as eslint plugin #24
Conversation
* develop: fix: update babel + add missing plugin fix: simplify check for better compat fix: add eslint disable to discard and effect fix: removes unsafe check fix: eslint errors fix: eslint error with --fix flag fix: ignore tests feat: changes eslint config + updates dependencies Creates new eslint config based on Airbnb`s one. Updates eslint versions and removes unused dependecies Payload of action did not fit to reducer anymore fix: restores retrySchedule and retryCount on rehydrate + uses initialState instead of magic values fix: squashes persisted netInfo with state`s netInfo
* develop: fix: package.json errors
Involved enough to warrant tests. Separating them into modules allows the integration point to be tested more easily as well.
|
See #22. |
Extract send from middleware
|
Awesome!! Thanks for all the help. Do you have a twitter account or email I can reach you at? Seems like something broke when I merged the other PR, and now travis is complaining. Could you take a look a it so we can merge this? Thanks again, amazing job! |
|
Another thing, I accidentally merged last PR into master. I'm trying to enforce git flow, I'm not reverting last PR, its too much hassle, but for the next PRs could you point them at the develop branch please. 🙏 |
|
Oh right, I didn't really notice the develop branch, sorry about that. I'll direct my PRs there from now on. You can reach me at [email protected]. I do not twitter. I'll take a look at the error now. |
|
Just needed to apply prettier to PR#23 as any differences register as lint errors now. |
Compares prettier output to actual code when
yarn lintis run, reporting the differences as errors.yarn prettierapplies the changes using the--fixflag.