-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script Updates #6
base: mainline
Are you sure you want to change the base?
Conversation
Looks like a completely different script. I tested it a long time ago but what are absolutely necessary changes and what can be omitted? Changing default boot size, disk name, pulling mandatory yandex binhost that could have availability problems due to sanctions, installing eix, using genkernel when it is not used to build the kernel, adding Pulling binary kernel is actually a good thing, LIVE_CD code path can be removed if binary kernel is working well and allow to build kernel extensions etc. Or live cd code path can be replaced with binary kernel. The whole purpose of LIVE CD KERNEL code path is to make install faster. Using binary host is probably a good idea but we might need to pull it in separate script because it impacts code too much. Also, default server for packages should not point to yandex mirror if we wanted to make it work worldwide for sure. I would prefer to keep it more vanilla without using binhost but it is ok to use binary packages from gentoo repo. |
Thanks for your responses.
More than happy to compromise. it's your project. 👍 |
Ideas that likely deserve separate issues/PR's outside the scope of this script update:
|
Gentoo Handbook Changes to Mount:
|
Alright, I think this as barebones as it can be now. Let me know if more changes are required. |
@sormy let me know if anything needs to be changed. Once this PR is merged, I'l begin working on the other issues. |
gentoo-quick-installer.sh
Outdated
|
||
emerge sys-kernel/gentoo-sources | ||
# required to allow for linux-firmware (required for binary kernel). | ||
echo "ACCEPT_LICENSE=\"*\"" >> /etc/portage/make.conf/default | ||
|
||
if [ "$USE_LIVECD_KERNEL" = 0 ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I suggest to have something like GENTOO_BINARY=0/1. This flag will help to install in fastest way all binary. Otherwise standard kernel installation and package compilation will be used. What do you think? And USE_LIVECD_KERNEL can be deprecated with relevant code that copies kernel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very interesting question. Is the purpose of the script to install packages as fast as possible?
I would be inclined to say that the entire script should be focused on installing via binary, and that compilation should be avoided if at all possible. As OSU's OSL's Stage 4 exists and is considered official, the only logical reason for source building is if you wanted to enable -march=native in the CFLAGS for that extra 1-2% performance.
If you really wanted to include a GENTOO_BINARY flag, probably best to just set it to 1 internally. Otherwise, I'd just omit the variable entirely, and set it. This issue might be out of the scope of this update, and I'll do a separate PR for binary and emerge -g
to keep this one simple to merge. We can absolutely remove USE_LIVECD_KERNEL, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Building kernel from the source can be needed if you want to build custom kernel module.
This CR removes completely this option, i would keep it, the rest is good.
gentoo-quick-installer.sh
Outdated
# /dev/sda is standard for most IDE/SATA drives. | ||
# /dev/nvme0n1 is standard for NVME drives. | ||
# /dev/mmcblk0 is standard for most eMMC and SD drives | ||
TARGET_DISK=/dev/vda |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might make it TARGET_DISK=${TARGET_DISK:-/dev/sda}
.
This script was created for installation in VirtualBox. We can keep default for backward compatibility but still allowing to override disk name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue with this idea is the weird hybrid it creates with the script, where you're either expected to hand-edit it (GENTOO_STAGE3 and TARGET_DISK) to make sure it works, and issue envars while running the command afterwards. for the purposes of automation and being run from other scripts, hand-editing scripts is less desireable.
I'll change both TARGET_DISK and GENTOO_STAGE3 for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree
eix added/synced