[ML] Fixes bug with category filtering flag for rare/population chart…

…s. (elastic#24901) (elastic#24920) Fixes a bug where the filtering limit of categories for the rare chart was actually applied to the population chart variant.
sorenlouv · Nov 1, 2018 · 11429c8 · 11429c8
1 parent c300e25
commit 11429c8
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/...er_charts/components/explorer_chart_label/__snapshots__/explorer_chart_label.test.js.snap b/...er_charts/components/explorer_chart_label/__snapshots__/explorer_chart_label.test.js.snap
@@ -8,7 +8,9 @@ exports[`ExplorerChartLabelBadge Render the chart label in one line. 1`] = `
     <span
       className="ml-explorer-chart-label-detector"
     >
-      high_sum(nginx.access.body_sent.bytes) over nginx.access.remote_ip (population-03)
+      <React.Fragment>
+        high_sum(nginx.access.body_sent.bytes) over nginx.access.remote_ip (population-03)
+      </React.Fragment>
       <React.Fragment>
          – 
       </React.Fragment>
@@ -64,7 +66,9 @@ exports[`ExplorerChartLabelBadge Render the chart label in two lines. 1`] = `
     <span
       className="ml-explorer-chart-label-detector"
     >
-      high_sum(nginx.access.body_sent.bytes) over nginx.access.remote_ip (population-03)
+      <React.Fragment>
+        high_sum(nginx.access.body_sent.bytes) over nginx.access.remote_ip (population-03)
+      </React.Fragment>
       <React.Fragment>
          
       </React.Fragment>

diff --git a/...lic/explorer/explorer_charts/components/explorer_chart_label/explorer_chart_label.test.js b/...lic/explorer/explorer_charts/components/explorer_chart_label/explorer_chart_label.test.js
@@ -11,14 +11,15 @@ import React from 'react';
 
 import { ExplorerChartLabel } from './explorer_chart_label';
 
+const DetectorLabel = <React.Fragment>{seriesConfig.detectorLabel}</React.Fragment>;
 
 describe('ExplorerChartLabelBadge', () => {
 
   test('Render the chart label in one line.', () => {
 
     const wrapper = shallow(
       <ExplorerChartLabel
-        detectorLabel={seriesConfig.detectorLabel}
+        detectorLabel={DetectorLabel}
         entityFields={seriesConfig.entityFields}
         infoTooltip={seriesConfig.infoTooltip}
         wrapLabel={false}
@@ -32,7 +33,7 @@ describe('ExplorerChartLabelBadge', () => {
 
     const wrapper = shallow(
       <ExplorerChartLabel
-        detectorLabel={seriesConfig.detectorLabel}
+        detectorLabel={DetectorLabel}
         entityFields={seriesConfig.entityFields}
         infoTooltip={seriesConfig.infoTooltip}
         wrapLabel={true}

diff --git a/x-pack/plugins/ml/public/explorer/explorer_charts/explorer_chart_distribution.js b/x-pack/plugins/ml/public/explorer/explorer_charts/explorer_chart_distribution.js
@@ -124,9 +124,9 @@ export class ExplorerChartDistribution extends React.Component {
         .filter((d, i) => {
           // only filter for rare charts
           if (chartType === CHART_TYPE.EVENT_DISTRIBUTION) {
-            return true;
+            return (i < categoryLimit || d.key === highlight);
           }
-          return (i < categoryLimit || d.key === highlight);
+          return true;
         })
         .map(d => d.key);