Remove untyped methods from activerecord.rbi #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No reason to have all these methods, they only make maintaining forward/backward compatibility more difficult for no benefit. If you want to know all the methods that exist in ActiveRecord, you should be generating gem RBIs with Sorbet or Tapioca. I've left in mixes_in_class_methods usages, to make sure that this commit doesn't remove anything that `srb rbi gems` wouldn't know about itself. This resolves a lot of issues with the RBI (e.g. different arguments between these sigs and the actual methods in rails).
|
I'm fine to land this but can you ask in the #rails channel on Slack and confirm whether this is something most people want? |
hdoan741
approved these changes
Mar 22, 2021
jez
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No reason to have all these methods, they only make maintaining forward/backward compatibility more difficult for no benefit.
If you want to know all the methods that exist in ActiveRecord, you should be generating gem RBIs with Sorbet or Tapioca.
I've left in mixes_in_class_methods usages, to make sure that this commit doesn't remove anything that
srb rbi gemswouldn't know about itself.This resolves a lot of issues with the RBI (e.g. different arguments between these sigs and the actual methods in rails).