Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gem RBI again #110

Merged
merged 6 commits into from
Aug 12, 2019
Merged

Add Gem RBI again #110

merged 6 commits into from
Aug 12, 2019

Conversation

connorshea
Copy link
Contributor

You'll note that the branch is the same as #92 (but with one extra commit to remove some untyped sigs I missed last time).

The reason we reverted #92 was because of the issue reported in #105. However, I'm able to reproduce that problem without any gem.rbi. The problem happened to be noticed at the same time as gem.rbi was merged in, but it's entirely unrelated.

The problem is caused by bundler.rbi being changed from true to strong, presumably because srb rbi sorbet-typed sets all the sorbet-typed RBIs to strong and doesn't run suggest-typed.

You can reproduce this in any project by changing the sigil in bundler.rbi to anything above true. The issue is fixed by running suggest-typed to update the type sigils in all the files in a project.

You can see this in my project, where I made a commit that changed bundler.rbi to typed: strong. It was passing before, and failed with the issue described in #105 afterward. gem.rbi does not exist in either commit.

srb tc job log, no gem.rbi, bundler.rbi set to typed: true: https://gitlab.com/connorshea/VideoGameList/-/jobs/269507607

srb tc job log, no gem.rbi, bundler.rbi set to typed: strong: https://gitlab.com/connorshea/VideoGameList/-/jobs/269956305

@connorshea connorshea requested a review from a team August 10, 2019 16:41
@ghost ghost requested review from elliottt and removed request for a team August 10, 2019 16:41
Copy link
Contributor

@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sorting out what happened in #105!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants