Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You'll note that the branch is the same as #92 (but with one extra commit to remove some untyped sigs I missed last time).
The reason we reverted #92 was because of the issue reported in #105. However, I'm able to reproduce that problem without any
gem.rbi
. The problem happened to be noticed at the same time asgem.rbi
was merged in, but it's entirely unrelated.The problem is caused by
bundler.rbi
being changed fromtrue
tostrong
, presumably becausesrb rbi sorbet-typed
sets all the sorbet-typed RBIs to strong and doesn't runsuggest-typed
.You can reproduce this in any project by changing the sigil in
bundler.rbi
to anything abovetrue
. The issue is fixed by runningsuggest-typed
to update the type sigils in all the files in a project.You can see this in my project, where I made a commit that changed
bundler.rbi
totyped: strong
. It was passing before, and failed with the issue described in #105 afterward.gem.rbi
does not exist in either commit.srb tc
job log, nogem.rbi
,bundler.rbi
set totyped: true
: https://gitlab.com/connorshea/VideoGameList/-/jobs/269507607srb tc
job log, nogem.rbi
,bundler.rbi
set totyped: strong
: https://gitlab.com/connorshea/VideoGameList/-/jobs/269956305