[FEATURE] org admin 빈 곳 있을 시 해당 섹션으로 이동 #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploying sopt-admin with
|
| Latest commit: |
2890184
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://089d0921.sopt-admin.pages.dev |
| Branch Preview URL: | https://feature-org-common-fill-yb.sopt-admin.pages.dev |
lydiacho
reviewed
Dec 31, 2024
Comment on lines
+23
to
+36
| ...['OB', 'YB'].flatMap((group) => | ||
| [ | ||
| 'applicationStartTime', | ||
| 'applicationEndTime', | ||
| 'applicationResultTime', | ||
| 'interviewStartTime', | ||
| 'interviewEndTime', | ||
| 'finalResultTime', | ||
| ].map((time) => ({ | ||
| name: `recruitSchedule.${group}.${time}`, | ||
| value: recruitSchedule?.[group]?.[time], | ||
| })), | ||
| ), | ||
| ...['main', 'low', 'high', 'point'].map((color) => ({ |
There was a problem hiding this comment.
요런 배열 값들 하드코딩하기보단 어차피 form item들이랑 일대일대응될 테니까 스키마에서 배열 뽑아와도 될 수 것 같기도 하네욤
There was a problem hiding this comment.
오홍 좋은 거 같아요! 시도해보고 말씀드릴게요 :)
| validationCommonInputs(getValues, setError, setGroup); | ||
| const handleValidationAboutInputs = () => | ||
| validationAboutInputs( | ||
| getValues, |
There was a problem hiding this comment.
얘네 getValues는 함수 자체를 넘겨주는 방식 외에도, handler 내에서 getValues로 해당 validation에 필요한 필드값들 뽑고, 걔네를 객체로 묶어서 전달해주는 것도 깔끔할 것 같은데 어떻게 생각하시나욤?
There was a problem hiding this comment.
아ㅏㅏ 그래도 되는데 그러면 해당 객체에 대한 타입들 또 지정해줘야 해서 고냥 바로 getValues 넘겨줬습니다
통일성도 있고 나쁘지 않은 거 같아서요!
eonseok-jeon
changed the base branch from
refactor-org-register-naming
to
dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ PR Point
더 효율적인 방법이 없을까 고민을 많이 했는데 찾지 못했어요
일일이 다 값 비교해보고 빈 값 있으면 해당 섹션으로 이동하게 했어요
홈 탭은 아직 주용이 pr 머지 안 되어서 일단 그대로 뒀어요
일단 현재 페이지에 빈 곳이 있는지 없는지 체크를 먼저하게 했어요
특히 Chip을 이용하는 곳은 빈 곳이 있을 경우 해당 Chip이 선택 되도록 했어요
여러 곳이 비어있다면 그 중 제일 첫 번째 input만 error 처리 되도록 했어요
다 채워져 있다면 공통 -> 홈 -> 소개 -> 지원하기 탭 순으로 체크하게 했습니다
추가로 빈 필드가 있을 시 error toast가 뜨도록 구현했어요
앞으로 해야할 것