Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] layout main 태그가 자식 요소에 중첩되는 문제 해결 #175

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

Brokyeom
Copy link
Member

✨ 구현 기능 명세

  • layout 에서 적용된 padding 값이 하위 요소의 main 요소에 중첩되어 적용되는 문제를 수정합니다.
  • 선택자 지정을 통해 layout의 자식 main에만 padding이 적용되도록 수정했어요.

AS-IS

image

TO-BE

image

✅ PR Point

😭 어려웠던 점

@Brokyeom Brokyeom requested a review from sohee-K December 23, 2024 03:44
@Brokyeom Brokyeom self-assigned this Dec 23, 2024
Copy link

height bot commented Dec 23, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

cloudflare-workers-and-pages bot commented Dec 23, 2024

Deploying sopt-admin with  Cloudflare Pages  Cloudflare Pages

Latest commit: f791d77
Status: ✅  Deploy successful!
Preview URL: https://92f4ebf1.sopt-admin.pages.dev
Branch Preview URL: https://fix-layout-main.sopt-admin.pages.dev

View logs

@Brokyeom
Copy link
Member Author

📝
단순 선택자 변경이기 때문에 하위 요소에 추가 영향을 주는 요소 발견하지 못했음.
따라서 선 머지 후 생기는 이펙트에 대해서는 추후 대응 예정

@Brokyeom Brokyeom merged commit df7952e into dev Dec 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant