Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: app be를 위한 스터디 수 조회 API 구현 #489

Merged
merged 15 commits into from
Nov 21, 2024
Merged

feat: app be를 위한 스터디 수 조회 API 구현 #489

merged 15 commits into from
Nov 21, 2024

Conversation

hoonyworld
Copy link
Member

@hoonyworld hoonyworld commented Nov 17, 2024 •
edited
Loading

👩‍💻 Contents

  • app be를 위해 스터디 수 조회 API를 구현했습니다.
  • 솝커톤 조회 API의 경우 아직 앱쪽에서 기획 확정이 되지 않아서 보류하고 작업했습니다.

📝 Review Note

[2024.11.19, 23:11]

  • 앱 측에서 스터디 수 조회 API만 필요하다는 의견이 다시 나와, 스터디 수 조회 API만 구현하기로 결정하였습니다.

📣 Related Issue

✅ 점검사항

  • docker-compose.yml 파일에 마이그레이션 한 API의 포워딩을 변경해줬나요?
  • Spring Secret 값을 수정하거나 추가했다면 Github Secret에서 수정을 해줬나요?
  • Nestjs Secret 값을 수정하거나 추가했다면 Docker-Compose.yml 파일 및 인스턴스 내부의 .env 파일을 수정했나요?

@hoonyworld hoonyworld linked an issue Nov 17, 2024 that may be closed by this pull request
feat: app be를 위한 스터디 수 조회 API 개발 #488
Closed
1 task
@height Height
Copy link

height bot commented Nov 17, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@hoonyworld hoonyworld requested a review from mikekks November 17, 2024 09:28
mikekks
mikekks reviewed Nov 17, 2024
View reviewed changes
Copy link
Member

@mikekks mikekks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 !!

궁금한 부분은 리뷰 남겼씁니다 :) 👍

main/src/main/java/org/sopt/makers/crew/main/internal/service/InternalMeetingStatsService.java Show resolved Hide resolved
main/src/main/java/org/sopt/makers/crew/main/internal/service/InternalMeetingStatsService.java Outdated Show resolved Hide resolved
main/src/main/java/org/sopt/makers/crew/main/entity/apply/ApplyRepository.java Outdated Show resolved Hide resolved
main/src/main/java/org/sopt/makers/crew/main/internal/dto/ApprovedStudyCountProjection.java Outdated Show resolved Hide resolved
@hoonyworld hoonyworld added the 🎁 feature 새로운 기능 label Nov 19, 2024
mikekks
mikekks previously approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@mikekks mikekks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!
리뷰가 조금 길어져 딜레이 된 점 죄송합니다.. ㅎㅎ..
앞으로도 개발적으로 많이 얘기해보면 좋을 것 같습니다 !!

main/src/main/java/org/sopt/makers/crew/main/entity/apply/ApplyRepository.java Show resolved Hide resolved
@hoonyworld hoonyworld merged commit 0363543 into develop Nov 21, 2024
1 check passed
@hoonyworld hoonyworld deleted the feat/#488 branch November 21, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikekks mikekks mikekks approved these changes

Assignees

@hoonyworld hoonyworld

Labels
🎁 feature 새로운 기능 size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: app be를 위한 스터디 수 조회 API 개발
2 participants
@hoonyworld @mikekks